Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: classify signalling mutlisig proposals as succeeded after the end date has passed #303

Merged
merged 17 commits into from
Nov 27, 2023
Merged

feat: classify signalling mutlisig proposals as succeeded after the end date has passed #303

merged 17 commits into from
Nov 27, 2023

Conversation

heueristik
Copy link
Contributor

@heueristik heueristik commented Nov 15, 2023 •
edited
Loading

Description

Task ID: OS-854

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them when possible.
  • I have updated the CHANGELOG.md file in the root folder of the package after the [UPCOMING] title and before the latest version.
  • I have tested my code on the test network.

@heueristik heueristik changed the title WIP: signalling proposal multisig fix feature: classify signalling mutlisig proposals as succeeded after the end date has passed Nov 17, 2023
heueristik

This comment was marked as outdated.

Sign in to view

@heueristik heueristik marked this pull request as ready for review November 17, 2023 14:42
@heueristik heueristik changed the title feature: classify signalling mutlisig proposals as succeeded after the end date has passed fix: classify signalling mutlisig proposals as succeeded after the end date has passed Nov 17, 2023
@heueristik heueristik force-pushed the feature/OS-854-signalling-proposal-filtering branch from df34f23 to 524c4f3 Compare November 23, 2023 08:53
josemarinas
josemarinas previously approved these changes Nov 23, 2023
View reviewed changes
@heueristik heueristik added client-release Publishes the current version of client subpackage on NPM common-release Publishes the current version of common subpackage on NPM labels Nov 23, 2023
josemarinas
josemarinas previously approved these changes Nov 24, 2023
View reviewed changes
Rekard0
Rekard0 previously approved these changes Nov 24, 2023
View reviewed changes
@heueristik heueristik dismissed stale reviews from Rekard0 and josemarinas via 2e6c804 November 24, 2023 10:39
josemarinas
josemarinas suggested changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@josemarinas josemarinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems ok but the rebase fucked the version in modules/client/package.json, should be 1.19.4 or 1.20.0 not 1.19.3, if this is not changed a new release wont be published

@heueristik
Copy link
Contributor Author

Everything seems ok but the rebase fucked the version in modules/client/package.json, should be 1.19.4 or 1.20.0 not 1.19.3, if this is not changed a new release wont be published

Fixed in ab42944

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 27, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
28.2% 28.2% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@heueristik heueristik merged commit c3a19eb into develop Nov 27, 2023
9 of 10 checks passed
@heueristik heueristik deleted the feature/OS-854-signalling-proposal-filtering branch November 27, 2023 09:44
@heueristik heueristik changed the title fix: classify signalling mutlisig proposals as succeeded after the end date has passed feat: classify signalling mutlisig proposals as succeeded after the end date has passed Nov 27, 2023
@heueristik heueristik added client-common-release Releases a new version of the client-common package and removed common-release Publishes the current version of common subpackage on NPM labels Nov 27, 2023
@heueristik heueristik mentioned this pull request Nov 27, 2023
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josemarinas josemarinas josemarinas approved these changes

@Rekard0 Rekard0 Awaiting requested review from Rekard0

Assignees
No one assigned
Labels
client-common-release Releases a new version of the client-common package client-release Publishes the current version of client subpackage on NPM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@heueristik @Rekard0 @josemarinas